Skip to content

impl(bigtable): add benchmark command line arg to set metrics period - #16338

Open
scotthart wants to merge 2 commits into
googleapis:mainfrom
scotthart:bigtable_benchmark_metric_option
Open

impl(bigtable): add benchmark command line arg to set metrics period#16338
scotthart wants to merge 2 commits into
googleapis:mainfrom
scotthart:bigtable_benchmark_metric_option

Conversation

@scotthart

Copy link
Copy Markdown
Member

No description provided.

@scotthart
scotthart requested a review from a team as a code owner August 10, 2026 19:13
@product-auto-label product-auto-label Bot added the api: bigtable Issues related to the Bigtable API. label Aug 10, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new --metrics-period command-line option to the Bigtable benchmarks, allowing users to configure the frequency at which client-side metrics are exported. This includes parsing the option as a duration, validating that it is positive, and applying it to the connection options via MetricsPeriodOption. Relevant unit tests have also been added to verify the parsing, validation, and table creation behavior. The feedback suggests removing the redundant bigtable:: namespace prefix when setting the MetricsPeriodOption to maintain consistency with existing patterns in the file.

Comment thread google/cloud/bigtable/benchmarks/benchmark.cc Outdated
@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.23%. Comparing base (154f9ef) to head (43c4a89).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16338   +/-   ##
=======================================
  Coverage   92.23%   92.23%           
=======================================
  Files        2227     2227           
  Lines      209283   209312   +29     
=======================================
+ Hits       193026   193058   +32     
+ Misses      16257    16254    -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant