impl(bigtable): add benchmark command line arg to set metrics period - #16338
impl(bigtable): add benchmark command line arg to set metrics period#16338scotthart wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a new --metrics-period command-line option to the Bigtable benchmarks, allowing users to configure the frequency at which client-side metrics are exported. This includes parsing the option as a duration, validating that it is positive, and applying it to the connection options via MetricsPeriodOption. Relevant unit tests have also been added to verify the parsing, validation, and table creation behavior. The feedback suggests removing the redundant bigtable:: namespace prefix when setting the MetricsPeriodOption to maintain consistency with existing patterns in the file.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16338 +/- ##
=======================================
Coverage 92.23% 92.23%
=======================================
Files 2227 2227
Lines 209283 209312 +29
=======================================
+ Hits 193026 193058 +32
+ Misses 16257 16254 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
No description provided.