Skip to content

doc(oauth2): name the constructor parameter these classes actually take #16336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
karpovantonme wants to merge 1 commit into
base: main
Choose a base branch
from
Open

doc(oauth2): name the constructor parameter these classes actually take #16336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions google/cloud/internal/oauth2_authorized_user_credentials.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@ class AuthorizedUserCredentials : public Credentials {
/**
* Creates an instance of AuthorizedUserCredentials.
*
* @param rest_client a dependency injection point. It makes it possible to
* mock internal REST types. This should generally not be overridden
* @param client_factory a dependency injection point. It makes it possible
* to mock internal REST types. This should generally not be overridden
* except for testing.
*/
explicit AuthorizedUserCredentials(AuthorizedUserCredentialsInfo info,
Expand Down
6 changes: 3 additions & 3 deletions google/cloud/internal/oauth2_compute_engine_credentials.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,9 @@ class ComputeEngineCredentials : public Credentials {
/**
* Creates an instance of ComputeEngineCredentials.
*
* @param rest_client a dependency injection point. It makes it possible to
* mock internal libcurl wrappers. This should generally not be overridden
* except for testing.
* @param client_factory a dependency injection point. It makes it possible
* to mock internal libcurl wrappers. This should generally not be
* overridden except for testing.
*/
explicit ComputeEngineCredentials(std::string service_account_email,
Options options,
Expand Down
5 changes: 3 additions & 2 deletions google/cloud/internal/oauth2_impersonate_service_account_credentials.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,9 @@ class ImpersonateServiceAccountCredentials
/**
* Creates an instance of ImpersonateServiceAccountCredentials.
*
* @param current_time_fn a dependency injection point to fetch the current
* time. This should generally not be overridden except for testing.
* @param client_factory a dependency injection point. It makes it possible
* to mock internal REST types. This should generally not be overridden
* except for testing.
*/
explicit ImpersonateServiceAccountCredentials(
google::cloud::internal::ImpersonateServiceAccountConfig const& config,
Expand Down
6 changes: 2 additions & 4 deletions google/cloud/internal/oauth2_service_account_credentials.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,11 +252,9 @@ class ServiceAccountCredentials : public oauth2_internal::Credentials {
/**
* Creates an instance of ServiceAccountCredentials.
*
* @param rest_client a dependency injection point. It makes it possible to
* mock internal REST types. This should generally not be overridden
* @param client_factory a dependency injection point. It makes it possible
* to mock internal REST types. This should generally not be overridden
* except for testing.
* @param current_time_fn a dependency injection point to fetch the current
* time. This should generally not be overridden except for testing.
*/
explicit ServiceAccountCredentials(ServiceAccountCredentialsInfo info,
Options options,
Expand Down
Loading