Skip to content

chore(ci): run toys ci under bash so the Windows leg tests again - #436

Merged
torreypayne merged 1 commit into
mainfrom
chore/ci-windows-bash
Oct 12, 2026
Merged

torreypayne merged 1 commit into
mainfrom
chore/ci-windows-bash

Conversation

@torreypayne

@torreypayne torreypayne commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

#424 moved ${{ github.event_* }} (resolved by GitHub before the shell runs) into env: variables resolved by the step's shell. Because this step runs across a multi-OS matrix (ubuntu-latest, macos-latest, windows-latest), Linux/macOS default to bash ($VAR) while Windows defaults to pwsh ($env:VAR). On windows-latest, "$GITHUB_EVENT_*" resolved as unset local PowerShell variables (""), causing toys ci to silently skip all tests (Windows leg in run 36145726308).

Since no single env-var syntax resolves in both bash and pwsh, this sets shell: bash so "$GITHUB_EVENT_*" resolves across all matrix OSes.

Companion PRs: googleapis/google-cloud-ruby#36609, googleapis/ruby-core-libraries#78, googleapis/ruby-spanner#257.

On windows-latest the default run shell is pwsh, where "$VAR" reads an
unset PowerShell variable instead of the environment variable. Since
#424 moved the event values into env:, the Windows leg has passed empty
--github-event-name/--github-event-payload values to toys ci, which then
falls back to a local diff and tests nothing.

Set shell: bash on the step. Linux and macOS already default to bash.
@torreypayne
torreypayne merged commit a29f3fd into main Oct 12, 2026
18 of 19 checks passed
@torreypayne
torreypayne deleted the chore/ci-windows-bash branch October 12, 2026 18:11
@torreypayne torreypayne removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants