Skip to content

fix PHP 8.5 compatibility #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paupeinado wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix PHP 8.5 compatibility #810

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfff733
fix PHP 8.5 compatibility
paupeinado Mar 24, 2026
f6d1a82
make change compatible with previous PHP versions (8.0 - 8.4)
paupeinado Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions src/Google/AdsApi/Common/AdsSoapClient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,9 @@ public function __construct($wsdl, array $options = null)
}

/**
* The $uriParserClass parameter only exists on the parent method as of
* PHP 8.5, so it must not be forwarded on earlier versions.
*
* @see SoapClient::__doRequest
*/
#[\ReturnTypeWillChange]
Expand All @@ -94,12 +97,28 @@ public function __doRequest(
$location,
$action,
$version,
$one_way = 0
$one_way = 0,
?string $uriParserClass = null
) {
$request = SoapRequests::replaceReferences($request);
$response = parent::__doRequest($request, $location, $action, $version, $one_way);
if (PHP_VERSION_ID >= 80500) {
return parent::__doRequest(
$request,
$location,
$action,
$version,
$one_way,
$uriParserClass
);
}

return $response;
return parent::__doRequest(
$request,
$location,
$action,
$version,
$one_way
);
}

/**
Expand Down