Add a note to OptimizationContext::SharedNodeData about allowable usages. - #4775
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
Add a note to OptimizationContext::SharedNodeData about allowable usages.#4775copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
…ges. Some LLM agents recently tried to fix optimization bugs by smuggling data between passes/invocations of passes using the SharedNodeData to store shared state. This is not a behavior we want to allow. SharedNodeData is purely a performance optimization and the NodeData held within it must always be fully recreatable at any point. Add a note to the documentation to clue agents in on the fact that stashing data in this location is forbidden. PiperOrigin-RevId: 964356589
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a note to OptimizationContext::SharedNodeData about allowable usages.
Some LLM agents recently tried to fix optimization bugs by smuggling data between passes/invocations of passes using the SharedNodeData to store shared state.
This is not a behavior we want to allow. SharedNodeData is purely a performance optimization and the NodeData held within it must always be fully recreatable at any point.
Add a note to the documentation to clue agents in on the fact that stashing data in this location is forbidden.