Fix crash in IR minimizer when slicing operands of widening operations. - #4763
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
Fix crash in IR minimizer when slicing operands of widening operations.#4763copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
The IR minimizer can crash when attempting to slice operands of a node (such as a widening multiply) if the operands are narrower than the slice range of the node itself. This change adds a check to ensure all operands are wide enough before attempting to slice them, returning kDidNotChange if they are not. Regression tests are added to cover these scenarios. PiperOrigin-RevId: 963665638
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix crash in IR minimizer when slicing operands of widening operations.
The IR minimizer can crash when attempting to slice operands of a node (such as a widening multiply) if the operands are narrower than the slice range of the node itself. This change adds a check to ensure all operands are wide enough before attempting to slice them, returning kDidNotChange if they are not. Regression tests are added to cover these scenarios.