Drop is_signed from CoerceOperandForSharing; add optional out parameter to indicate negation - #4762
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
Drop is_signed from CoerceOperandForSharing; add optional out parameter to indicate negation#4762copybara-service[bot] wants to merge 1 commit into
is_signed from CoerceOperandForSharing; add optional out parameter to indicate negation#4762copybara-service[bot] wants to merge 1 commit into
Conversation
…ameter to indicate negation `is_signed` can be determined from the `to` node. The new out parameter lets a consumer understand if the coercion involved 2nd operand negation for applicable operations. PiperOrigin-RevId: 963655276
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop
is_signedfromCoerceOperandForSharing; add optional out parameter to indicate negationis_signedcan be determined from thetonode. The new out parameter lets a consumer understand if the coercion involved 2nd operand negation for applicable operations.