Split new case selection out of LUT conversion transform. - #4757
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
Split new case selection out of LUT conversion transform.#4757copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
Now, we can separately determine the case values for the LUT select before it gets merged into child selects. This will allow us to perform transforms outside of merge select, including building a new select node out of the case values. Unfortunately the query engine populated during candidate filtering still needs to be used during case value determination when looking at Node known values, so there is still some required coupling between the two methods. PiperOrigin-RevId: 960440011
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split new case selection out of LUT conversion transform.
Now, we can separately determine the case values for the LUT select before it gets merged into child selects. This will allow us to perform transforms outside of merge select, including building a new select node out of the case values.
Unfortunately the query engine populated during candidate filtering still needs to be used during case value determination when looking at Node known values, so there is still some required coupling between the two methods.