Preserve source locations in optimization passes - #4747
Open
rw1nkler wants to merge 2 commits into
Open
Conversation
ericastor
reviewed
Aug 13, 2026
ericastor
left a comment
ericastor
left a comment
Contributor
There was a problem hiding this comment.
This is a great step forward, thank you!
| for (const SourceLocation& location : operand->loc().locations) { | ||
| bool already_present = | ||
| absl::c_any_of(loc.locations, [&](const SourceLocation& existing) { | ||
| return existing <=> location == std::strong_ordering::equal; |
Contributor
There was a problem hiding this comment.
... is there a reason this isn't just absl::c_linear_search(loc.locations, existing)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
MergeLocshelper that merges and deduplicates source locations across a node's operands.It's used wherever passes synthesize replacement nodes, since those call sites often dropped the
original location, making it harder to trace optimized IR and generated Verilog back to the source DSLX.
VastNode::PreEmitis also updated to emit one comment per merged location, with line-count trackingadjusted accordingly. Tests cover
MergeLocsand each annotation strategy end to end.