Repository navigation
Conversation
A non-empty array such as "env": ["FOO"] reported "Expected an object" but then kept walking the array as if it were an object and threw an internal error. Return after reporting the failure.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a script's
"env"is not an object,#processEnvpushes an "Expected an object" failure but keeps going. If the value is a non-empty array, such as"env": ["FOO"], the loop then treats each array element as an object property, finds no key/value children, and throwsInternal error: expected object JSON node children to be key/val pairs. The CLI dies with that stack trace instead of printing the diagnostic, andIdeAnalyzer.getDiagnosticsrejects with the same error, so the editor never shows it either. An empty array (the case covered by the existing test) has no children, so it already worked.This returns right after reporting the "Expected an object" failure, like the other
#process*helpers do after a type error.Added a test in
errors-analysis.test.tsnext to the existing "env must be an object" test, using"env": ["FOO"]. It fails before the change (the stderr is the internal error stack) and passes after. Also added a CHANGELOG entry under Unreleased > Fixed.