Repository navigation
Conversation
The caller disposed the request before the body was read, so the detail was always empty.
aomarks
approved these changes
Sep 25, 2026
aomarks
left a comment
Member
There was a problem hiding this comment.
Thanks, looks like this was a regression. I also added a commit to this PR which fixes a related thing that turned up, we were trying to show the error body, but were not.
Author
|
Thanks for the review and for the follow up fix! |
Author
|
Hi @aomarks, friendly ping: this is approved and green. Is there anything else you need from me before it can be merged? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the GitHub Actions cache service returns a non-2xx status,
#maybeHandleServiceDownsets#serviceIsDown = trueand then starts an async task that reads the response body and logs why caching was disabled (rate limit, 503, or another HTTP error). That task first checksif (this.#serviceIsDown) return;, but the flag was set just before, so it always returns and the message is never logged. Network errors take the synchronous branch and are logged fine; only HTTP errors are silent.The concurrent-request dedup is already handled by the synchronous
#serviceIsDowncheck above, so this removes the extra check inside the async task.Added a test in
cache-github-fake.test.tsthat forces a 503 on the first cache lookup and checks that the simple logger prints the "temporarily unavailable" message. It fails before the change and passes after. Also added a CHANGELOG entry under Unreleased > Fixed.Related to #1330, where the expected behavior was to disable caching for the rest of the run and warn.