De-std::atomic Span::allocated_.#348
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_945244330
branch
9 times, most recently
from
ae59adc to
75ba14c
Compare
This prevents the compiler from merging redundant load/store operations. This is especially pronounced on InsertRange, while RemoveRange appears to have enough memory pressure that we will need to spill anyways. Since the turndown of the fragmentation profile, we no longer need to keep `Span::Allocated()` safe for accessing across threads so an ordinary integer will suffice. PiperOrigin-RevId: 947690429
copybara-service
Bot
force-pushed
the
test_945244330
branch
from
75ba14c to
c2b022c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
De-std::atomic Span::allocated_.
This prevents the compiler from merging redundant load/store operations. This
is especially pronounced on InsertRange, while RemoveRange appears to have
enough memory pressure that we will need to spill anyways.
Since the turndown of the fragmentation profile, we no longer need to keep
Span::Allocated()safe for accessing across threads so an ordinary integer will suffice.