internal/report: fix exact function matching in disasm - #1027
Open
IamPritamAcharya wants to merge 2 commits into
Open
internal/report: fix exact function matching in disasm#1027IamPritamAcharya wants to merge 2 commits into
IamPritamAcharya wants to merge 2 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1015.
The web UI converts a selected function name into an exact regexp, for example:
disasmbuilds its report with address granularity. At that granularity,NodeInfo.PrintableName()also contains the address and source location:symbolsFromBinariesused the regexp against this printable name when decidingwhich binary mappings to inspect. An exact function-name regexp could therefore
reject the mapping before
ObjFile.Symbolshad a chance to match the binarysymbol name.
Update the preliminary mapping check to also match
NodeInfo.Name, which is thefunction name represented by the web UI selection. Keep the existing
PrintableName()check to avoid narrowing previously supported matchingbehavior. Final symbol selection continues to be performed by
ObjFile.Symbols.The regression test exercises the web
/disasmhandler with an anchoredfunction regexp. It failed with
no matches found for regexp ^F2$before thischange. The existing unanchored disassembly case remains covered.
Validation:
go test -v ./...(cd browsertests && go test)