Upload Lua scripts to Valkey for quota management - #3215
Merged
Conversation
gbrodman
force-pushed
the
uploadLuaScripts
branch
from
August 20, 2026 16:49
d75f31b to
566be81
Compare
We don't want to have to pass the entire script to Valkey every single time. Instead, we compute the SHA-1 hash of the script and refer to it by hash, significantly reducing the amount of bytes we need to send to the server. If the script is not loaded in Valkey (NOSCRIPT error), we reload it and retry.
gbrodman
force-pushed
the
uploadLuaScripts
branch
from
August 20, 2026 16:53
566be81 to
a5db76c
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
weiminyu
approved these changes
Aug 20, 2026
weiminyu
left a comment
weiminyu
left a comment
Collaborator
There was a problem hiding this comment.
@weiminyu partially reviewed 3 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on gbrodman).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't want to have to pass the entire script to Valkey every single
time. Instead, we compute the SHA-1 hash of the script and refer to it
by hash, significantly reducing the amount of bytes we need to send
to the server. If the script is not loaded in Valkey (NOSCRIPT error),
we reload it and retry.
This change is