Split QuotaManager into generic and EppServer classes - #3213
Merged
Conversation
This separates the logic of "how many tokens should a particular user/group have" from "manage the quota given whatever limits, contacting Valkey". This is in preparation for allowing other types of quota management and throttling besides just on the EPP server (e.g. domain-create throttling). We also convert the expirations from seconds to milliseconds (and use a Duration so that this is masked from users). It's better to have the API use a full-fledged Duration object rather than an int, and this allows for finer control over expiration times. Note that we'll probably want to use a sliding window in the future instead of a fixed window, but that's a problem for future us.
gbrodman
force-pushed
the
refactorQuotaManager
branch
from
August 18, 2026 17:01
52205ac to
0eb76b5
Compare
weiminyu
approved these changes
Aug 19, 2026
weiminyu
left a comment
weiminyu
left a comment
Collaborator
There was a problem hiding this comment.
@weiminyu reviewed 9 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on gbrodman).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This separates the logic of "how many tokens should a particular user/group have" from "manage the quota given whatever limits, contacting Valkey".
This is in preparation for allowing other types of quota management and throttling besides just on the EPP server (e.g. domain-create throttling).
We also convert the expirations from seconds to milliseconds (and use a Duration so that this is masked from users). It's better to have the API use a full-fledged Duration object rather than an int, and this allows for finer control over expiration times.
Note that we'll probably want to use a sliding window in the future instead of a fixed window, but that's a problem for future us.
This change is