Repository navigation
Fix C++ CMake build on Ubuntu 26.04 (Boost >= 1.89 and Abseil deprecated-declarations) - #4099
Merged
Merged
Conversation
…ted-declarations)
katbohm
approved these changes
Nov 5, 2026
tvislavski
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compiling PhoneNumberOfflineGeocoder::~PhoneNumberOfflineGeocoder (line 80) and PhoneNumberOfflineGeocoder::GetAreaDescription (line 198) fails on absl::MutexLock l(&mu_); with:
Fix for Build C++: In CMakeLists.txt, add -Wno-deprecated-declarations (the same flag used to build locally in opensource_metadata):
(Note: Using -Wno-deprecated-declarations in CMakeLists.txt is safer than changing absl::MutexLock l(&mu_); to absl::MutexLock l(mu_); in phonenumber_offline_geocoder.cc, because when absl is not installed on the system, CMakeLists.txt falls back to fetching Abseil 273292d from 2021, which only has the pointer constructor MutexLock(Mutex).)*