Skip to content

core: reduce MAX_PARSER_DEPTH to prevent stack overflow on deep nesting #1339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jdymitarai wants to merge 1 commit into
base: master
Choose a base branch
from
Open

core: reduce MAX_PARSER_DEPTH to prevent stack overflow on deep nesting #1339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/parser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ static const Fodder EMPTY_FODDER;
* This is especially important when parsing deeply nested structures that could lead to
* excessive recursion in the parser functions.
*/
static const unsigned MAX_PARSER_DEPTH = 1000;
static const unsigned MAX_PARSER_DEPTH = 500;

static bool op_is_unary(const std::string &op, UnaryOp &uop)
{
Expand Down
2 changes: 1 addition & 1 deletion test_suite/error.parse.deep_array_nesting.jsonnet.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
STATIC ERROR: error.parse.deep_array_nesting.jsonnet:1:501: Exceeded maximum parse depth limit.
STATIC ERROR: error.parse.deep_array_nesting.jsonnet:1:251: Exceeded maximum parse depth limit.
Expand Down
1 change: 1 addition & 0 deletions test_suite/error.parse.deep_if_nesting.jsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else if true then 1 else 1
2 changes: 2 additions & 0 deletions test_suite/error.parse.deep_if_nesting.jsonnet.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
STATIC ERROR: error.parse.deep_if_nesting.jsonnet:1:9984-9988: Exceeded maximum parse depth limit.

Loading