Repository navigation
Add JsonPrimitive.TRUE, FALSE, and of(boolean) - #3177
Merged
Merged
Conversation
Introduce public singleton constants `JsonPrimitive.TRUE` and `JsonPrimitive.FALSE` along with `JsonPrimitive.of(boolean)`, and use `JsonPrimitive.of(...)` across Gson (`JsonArray`, `JsonObject`, `JsonElementTypeAdapter`, `JsonTreeWriter`, and `StructTypeAdapter`) instead of allocating a new `JsonPrimitive` instance per boolean value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce public singleton constants
JsonPrimitive.TRUEandJsonPrimitive.FALSEalong withJsonPrimitive.of(boolean), and useJsonPrimitive.of(...)across Gson (JsonArray,JsonObject,JsonElementTypeAdapter,JsonTreeWriter, andStructTypeAdapter) instead of allocating a newJsonPrimitiveinstance per boolean value.We might later want to add other
JsonPrimitive.ofmethods, for example to enable reusing objects for small integer values, but that's a less clear win than forboolean.We could also conceivably deprecate the
JsonPrimitive(boolean)constructor in favour ofJsonPrimitive.of(boolean).