Repository navigation
feat: Add BundleURL to Attestation - #4647
Open
Frank2006x wants to merge 2 commits into
Open
Frank2006x wants to merge 2 commits into
Frank2006x wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4647 +/- ##
========================================
Coverage 98.61% 98.62%
========================================
Files 199 201 +2
Lines 18689 18811 +122
========================================
+ Hits 18431 18553 +122
Misses 258 258 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gmlewis
approved these changes
Oct 18, 2026
gmlewis
left a comment
gmlewis
left a comment
Collaborator
There was a problem hiding this comment.
Thank you, @Frank2006x!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
Not-Dhananjay-Mishra
approved these changes
Oct 19, 2026
Not-Dhananjay-Mishra
left a comment
Not-Dhananjay-Mishra
left a comment
Contributor
There was a problem hiding this comment.
Just one nit. Otherwise, LGTM 🚀
| // The provided bundle can be used to verify the provenance of artifacts. | ||
| // | ||
| // https://docs.github.com/en/actions/security-for-github-actions/using-artifact-attestations/using-artifact-attestations-to-establish-provenance-for-builds | ||
| type Attestation struct { |
Contributor
There was a problem hiding this comment.
initiator field is also missing from the Attestation struct, Can you add that as well?
"bundle_url": {
"type": "string"
},
"initiator": {
"type": "string"
}
Contributor
Author
|
Added the initiator into the Attestation struct as requested |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
BundleURL *stringtoAttestationand addsomitemptytoBundle. The GitHub REST API for artifact attestations now providesbundle_urlto download the Sigstore bundle instead of returning the bundle inline.This addresses the Attestations: Remove the bundle property from attestation list responses (users should use bundle_url instead). #4077 (comment).
part of #4077
Tests
go test ./github script/test.sh script/lint.shAssisted Contribution
Drafted with the assistance of an AI coding agent. All changes and test results were reviewed and verified against repository
guidelines.