Fix false positive UnrecognisedJavadocTag with Lombok annotations#5956
Open
ayushkumar9449 wants to merge 1 commit into
Open
Fix false positive UnrecognisedJavadocTag with Lombok annotations#5956ayushkumar9449 wants to merge 1 commit into
ayushkumar9449 wants to merge 1 commit into
Conversation
Fixes google#5855 - UnrecognisedJavadocTag checker was reporting false positives when Lombok annotations (@Getter, @Setter, etc.) were present on classes or fields with valid {&google#64;link} or {&google#64;code} Javadoc tags. Root cause: Annotation-related position offsets in the AST caused position mismatches between regex-found tags and DocTree-recognized tags, resulting in false positives. Solution: Added validation to check if tags are well-formed (end with '}'). Only report errors for genuinely malformed tags, not position mismatches due to annotation offsets. - Modified: UnrecognisedJavadocTag.java * Added isValidTag() method to check tag structure * Updated handle() to skip reporting for well-formed tags with position mismatches - Added test cases for Lombok @Getter on both class and field level
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5855 - UnrecognisedJavadocTag checker was reporting false positives when Lombok annotations (@Getter, @Setter, etc.) were present on classes or fields with valid {@link} or {@code} Javadoc tags.
Root cause: Annotation-related position offsets in the AST caused position mismatches between regex-found tags and DocTree-recognized tags, resulting in false positives.
Solution: Added validation to check if tags are well-formed (end with '}'). Only report errors for genuinely malformed tags, not position mismatches due to annotation offsets.