Skip to content

Add R8 keep rule for Hilt_* base classes to fix ClassCastException in release builds #5195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Senthil455 wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −2
Open

Add R8 keep rule for Hilt_* base classes to fix ClassCastException in release builds #5195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion hilt-android/main/resources/META-INF/com.android.tools/proguard/hilt-android.pro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,9 @@
# See b/183070411#comment4 for more info.
-keep,allowobfuscation,allowshrinking @dagger.hilt.internal.ComponentEntryPoint class *
-keep,allowobfuscation,allowshrinking @dagger.hilt.internal.GeneratedEntryPoint class *
-keep,allowobfuscation,allowshrinking @dagger.hilt.android.EarlyEntryPoint class *
-keep,allowobfuscation,allowshrinking @dagger.hilt.android.EarlyEntryPoint class *

# Prevent R8 full mode from vertically merging Hilt_* base classes with
# @AndroidEntryPoint user classes. The bytecode transform rewrites user classes
# to extend Hilt_*; vertical class merging breaks this hierarchy.
-keep,allowobfuscation,allowshrinking class **.Hilt_*
7 changes: 6 additions & 1 deletion hilt-android/main/resources/META-INF/com.android.tools/r8/hilt-android.pro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,9 @@
# See b/183070411#comment4 for more info.
-keep,allowobfuscation,allowshrinking @dagger.hilt.internal.ComponentEntryPoint class *
-keep,allowobfuscation,allowshrinking @dagger.hilt.internal.GeneratedEntryPoint class *
-keep,allowobfuscation,allowshrinking @dagger.hilt.android.EarlyEntryPoint class *
-keep,allowobfuscation,allowshrinking @dagger.hilt.android.EarlyEntryPoint class *

# Prevent R8 full mode from vertically merging Hilt_* base classes with
# @AndroidEntryPoint user classes. The bytecode transform rewrites user classes
# to extend Hilt_*; vertical class merging breaks this hierarchy.
-keep,allowobfuscation,allowshrinking class **.Hilt_*