Project import generated by Copybara.#1511
Open
juergw wants to merge 1 commit into
Open
Conversation
PiperOrigin-RevId: 930364116
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PiperOrigin-RevId: 930364116
AndroidHpkeSpi was introduced to be able to use HPKE both in android and in Conscrypt. But since it implements an android interface, it can only be used if that interface is available.
But it turns out that this is not really needed. HpkeImpl (which only implements org.conscrypt.HpkeSpi) does work with the android android.crypto.hpke API, because that API accepts not only services that implement the android.crypto.hpke.HpkeSpi, but also (with the help of a Duck-typed adapter) any object that implements the same methods as org.conscrypt.HpkeSpi.
So we can simply always use HpkeImpl.
This resolves #1508.