Skip to content

feat(model): resolve word segmentation issue for おでかけ (#1332) - #1335

Merged
tushuhei merged 1 commit into
mainfrom
issue-1332
Aug 17, 2026
Merged

feat(model): resolve word segmentation issue for おでかけ (#1332)#1335
tushuhei merged 1 commit into
mainfrom
issue-1332

Conversation

@tushuhei

Copy link
Copy Markdown
Member
  • Add fine-tuning dataset data/finetuning/ja/issue_1332.txt for representative Japanese sentences containing 'おでかけ' segmented as a compound phrase.
  • Add general attributive verb samples ('つなぐ') to data/finetuning/ja/issue_994.txt without leaking test suite benchmark cases.
  • Recompile production Japanese model weights (budoux/models/ja.json) with 200,000 AdaBoost iterations via run_training_pipeline.py.
  • Add regression test case gh1332 ('おでかけに▁ピッタリ') to tests/quality/ja.tsv (100% pass rate).

Fixes: #1332 TAG=agy
CONV=da1ee413-f759-43cd-8f2d-90cf430c1f51

- Add fine-tuning dataset data/finetuning/ja/issue_1332.txt for representative Japanese sentences containing 'おでかけ' segmented as a compound phrase.
- Add general attributive verb samples ('つなぐ') to data/finetuning/ja/issue_994.txt without leaking test suite benchmark cases.
- Recompile production Japanese model weights (budoux/models/ja.json) with 200,000 AdaBoost iterations via run_training_pipeline.py.
- Add regression test case gh1332 ('おでかけに▁ピッタリ') to tests/quality/ja.tsv (100% pass rate).

Fixes: #1332
TAG=agy
CONV=da1ee413-f759-43cd-8f2d-90cf430c1f51
@tushuhei
tushuhei requested a review from kojiishi August 17, 2026 05:23

@kojiishi kojiishi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tushuhei
tushuhei merged commit d506395 into main Aug 17, 2026
43 checks passed
@tushuhei
tushuhei deleted the issue-1332 branch August 17, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[quality] おでかけ

2 participants