Make Javadoc CI jobs succeed when there is no change to the generated output.#2069
Merged
Conversation
… output. Truth's Javadoc-generation jobs has failed from [`d37a61a`](google/truth@d37a61a) onward. The trigger for the problem, however, is the commit _before_ that one, [`77c6a82`](google/truth@77c6a82): By upgrading to a new version of Javadoc, we put an end to [trivial changes to `.zip` files each time we regenerate the output](google/truth@ea9b387) (likely timestamps or directory ordering, similar to the complaints I've had in google/guava#7597). That meant that `git commit` started failing because there were no changes to the Javadoc output to commit after each of the recent changes to the code. (But the job for the Javadoc version itself succeeded because it naturally [did produce changes to the output](google/truth@4feaa60).) The fix is to just exit successfully when there is nothing to commit. I'm preemptively making this same change to Auto. RELNOTES=n/a PiperOrigin-RevId: 933236220
copybara-service
Bot
force-pushed
the
test_933215637
branch
from
929dc13 to
e201339
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make Javadoc CI jobs succeed when there is no change to the generated output.
Truth's Javadoc-generation jobs has failed from
d37a61aonward. The trigger for the problem, however, is the commit before that one,77c6a82: By upgrading to a new version of Javadoc, we put an end to trivial changes to.zipfiles each time we regenerate the output (likely timestamps or directory ordering, similar to the complaints I've had in google/guava#7597). That meant thatgit commitstarted failing because there were no changes to the Javadoc output to commit after each of the recent changes to the code. (But the job for the Javadoc version itself succeeded because it naturally did produce changes to the output.)The fix is to just exit successfully when there is nothing to commit.
I'm preemptively making this same change to Auto.
RELNOTES=n/a