Repository navigation
Conversation
- `ApplicationIntegrationToolset.__init__` opens its docstring with `Args:` and then repeats the heading on the next paragraph. The first one is replaced with a one-line summary; the real block is unchanged. - `OAuth2CredentialExchanger.generate_auth_token` documents an `auth_scheme` argument it does not take — the scheme is a constructor parameter of the exchanger. - `RestApiTool.from_parsed_operation_str` documents `parsed: A dict representation of a ParsedOperation object`, but the parameter is `parsed_operation_str: str` and the body calls `ParsedOperation.model_validate_json(...)` on it. Docstrings only: an AST comparison against the previous head is identical once docstrings are excluded, and `ruff check` on the three files passes before and after.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three docstrings in
src/google/adk/tools/do not match their functions:ApplicationIntegrationToolset.__init__"""Args:and then repeatsArgs:on the next paragraphOAuth2CredentialExchanger.generate_auth_tokenauth_schemeauth_credentialRestApiTool.from_parsed_operation_strparsed: A dict representation of a ParsedOperation objectparsed_operation_str: str, and the body callsParsedOperation.model_validate_json(...)on itThe third one is the one that would actually mislead: the type is wrong (
dictvsstr) as well as the name, so a reader passing a dict gets a validation error frommodel_validate_json.Verification
ruff checkon the three files:All checks passed!before and after.Note: this repo requires the Google CLA before merging.