Repository navigation
Conversation
_convert_interaction_step_to_parts documents an output parameter; the signature takes step: Step and the body branches on ModelOutputStep.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
2. Or, if no issue exists, describe the change:
Problem:
_convert_interaction_step_to_parts(src/google/adk/models/interactions_utils.py:758) documents a parameter it does not take:The parameter is
step: Step. TheArgs:entry is left over from a signature that took the interactionoutput; the body now branches onModelOutputStepand itscontentitems, so a reader looking foroutputfinds nothing, and the summary's "interaction output content" points at the wrong intermediate type as well.Solution:
Rename the entry to
stepand describe what the function actually receives:One file,
+1/−1, no code touched. I left the summary sentence alone: "Convert an interaction output content to a list of types.Part" describes the result accurately enough, and rewording it would make this a two-purpose diff.Verification:
ruff==0.15.17 checkon the file:All checks passed!pyink==25.12 --checkon the file:1 file would be left unchanged(this repository formats with pyink;ruff formatwould reformat the file both before and after this change, so it is not the formatting gate here).On the CLA: I have read
CONTRIBUTING.md; the Google CLA check on this PR will stay pending until the account holder signs it at cla.developers.google.com. Flagging it rather than leaving you to discover it — the code change itself is complete.Additional context
Found by parsing the tree with
astand comparing everyArgs:entry against the real signature (positional-only, keyword-only,*argsand**kwargsincluded). Insrc/google/adk, this is the only remaining entry that names something the signature does not accept — the two others undertools/openapi_tool/are already the subject of #8026, so I did not touch them.