Skip to content

docs(changelog): fix 2 dead commit permalinks - #7784

Open
leom1919 wants to merge 10 commits into
google:mainfrom
leom1919:docs-changelog-commit-links
Open

leom1919 wants to merge 10 commits into
google:mainfrom
leom1919:docs-changelog-commit-links

Conversation

@leom1919

@leom1919 leom1919 commented Oct 28, 2026 •

Copy link
Copy Markdown

Motivation

Dead links in CHANGELOG.md (all verified 404 / "No commit found" against the live repo):

Stale commit SHAs (internal pre-mirror history) → public equivalents

Line(s) Dead SHA Replacement (commit message matches entry verbatim)
803, 902 91573eb9…ef9a c274ac347ab91ed523a1da6fee3ec7d9fdb9ff8c — "fix!: rerun a failed node on resume instead of replaying it as complete"
804, 849 c5697961…2178 6f2ee9280abd5a1ebb0d35afbaf382b979d58982 — "fix!: confine GCS tool local file paths to a configured root"
805, 892 15b1392…92f8 c8bc126fd98e7fe062abce3fd62ac2bd3e96aebc — "fix!: raise SessionNotFoundError when appending to an unknown session"
906 2dc8b8d3…3718 dcdd9b8a72f6ef35f695b456c665e261e9df11ce — "fix!: retry a nested workflow when a node inside it fails"
3681 b4310727…ee8 b4310727d90421a81a8afc47e3c344646ee7aee2 — single-hex-digit typo; link text [b431072] already matches the real commit

References to issues that do not exist in this repository

  • Line 914: , closes [#4506](…) — removed (issue 404)
  • Line 1885: , closes [#12345](…) — removed (issue 404); likely internal-tracker references carried into the generated changelog

Relocated sample directory links

  • Line 3104: samples/interactions_api → samples/models/interactions_api
  • Line 3728: samples/oauth_calendar_agent → samples/integrations/oauth_calendar_agent
  • Line 3775: samples/output_schema_with_tools → samples/tools/output_schema_with_tools

Total: 10 line edits in CHANGELOG.md, entry text otherwise untouched.

Verification

  • Every dead SHA: GET /repos/google/adk-python/commits/{sha} → 422 "No commit found".
  • Every replacement SHA: resolves via the Commits API and its message matches the changelog entry description verbatim (found via commit search).
  • Both issue numbers: GET /repos/google/adk-python/issues/{n} → 404.
  • All three relocated sample paths verified to exist on main (and linked from the repo's own docs).

This is a small documentation fix (exempt from the issue requirement per CONTRIBUTING.md).

AI Assistance

This PR was created with AI assistance (automated dead-link scanning of the repository's markdown files, followed by manual verification of every replacement target via the GitHub API before submission).

@google-cla

google-cla Bot commented Oct 28, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@leom1919

Copy link
Copy Markdown
Author

Follow-up: a second scan pass (after retrying the rate-limited URLs from the initial sweep) found 5 more stale commit SHAs, 2 references to nonexistent issues, and 3 relocated sample paths — all fixed in commit 57cad01. PR description updated to the full scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants