fix: exclude thought parts from response match scoring - #7091
Open
MrCapricornLiu wants to merge 1 commit into
Open
fix: exclude thought parts from response match scoring#7091MrCapricornLiu wants to merge 1 commit into
MrCapricornLiu wants to merge 1 commit into
Conversation
Signed-off-by: Chenghao Liu <chliu@stu.pku.edu.cn>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The response-match evaluator counts text parts marked
thought=Trueas final-answer text. A correct answer can lose points because of its thought summary, and a wrong answer can receive credit for a word mentioned only in that summary. Exclude thought parts from both actual and reference text, preserving the existing tokenization and empty-response behavior.Reproduction and expected behavior
On ADK 2.8.0 / main (
2284c581), Linux, Python 3.12.13, run the added regression cases in:The added cases fail on the original implementation and pass with this change. No LiteLLM or live model endpoint is required; Runner verification uses a scripted
BaseLlmresponse.Testing Plan
Type checking matches the unmodified upstream baseline (831 existing errors; no new errors).
da10185e): 74 passed.2284c581was also verified in a clean environment.2284c581, Python 3.10–3.14: tests passed with the two GC-introspection cases run in separate processes (14,248 passing cases on Python 3.12). One unrelated MCP stdio teardown case was deselected after it also failed to finish on the unmodified base. The default uninterruptedtoxrun did not complete.Runner setup and reproduction output
Save the following as
repro.py, then runpython repro.pyafter installing the locally built wheel. Installrouge-scoreas well.