fix: use working-directory to resolve adk_pr_triaging_agent module path#5857
Open
qizwiz wants to merge 11 commits into
Open
fix: use working-directory to resolve adk_pr_triaging_agent module path#5857qizwiz wants to merge 11 commits into
qizwiz wants to merge 11 commits into
Conversation
Collaborator
|
Response from ADK Triaging Agent Hello @qizwiz, thank you for submitting this pull request to fix the triaging script module path issue! To help our reviewers process this change more efficiently, please ensure it aligns with our Contribution Guidelines. Currently, the following sections are missing from your PR description:
We appreciate your contribution and help in improving our CI/CD workflows! |
Covers: well-formed objects/arrays/primitives, malformed input raises ValueError, error message includes context label, __cause__ is JSONDecodeError, unicode content.
d3538d0 to
b2f1746
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The `agent-triage-pull-request` job fails with:
```
ModuleNotFoundError: No module named 'adk_pr_triaging_agent'
```
The module lives at `contributing/samples/adk_team/adk_pr_triaging_agent/`. Setting `PYTHONPATH` to a relative path is fragile and doesn't reliably add the directory to `sys.path`.
Fix
Replace the `PYTHONPATH` env var with `working-directory: contributing/samples/adk_team` on the triaging step. When Python is invoked with `-m`, it automatically adds the current working directory to `sys.path`, making `adk_pr_triaging_agent` importable without needing `PYTHONPATH` at all.
This is the same approach recommended by Copilot's analysis of the failure.
Testing plan