fix: support typed responseSchema in ChatCompletionsRequest - #1447
Open
hemasekhar-p wants to merge 1 commit into
Open
fix: support typed responseSchema in ChatCompletionsRequest#1447hemasekhar-p wants to merge 1 commit into
hemasekhar-p wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
Link to an existing issue (if applicable):
Problem:
When setting an output schema via LlmRequest.Builder.outputSchema(Schema) or LlmAgent.outputSchema(Schema), the schema is stored in GenerateContentConfig.responseSchema with responseMimeType = "application/json". In ChatCompletionsRequest.handleConfigOptions(...), only config.responseJsonSchema() was checked. Because responseJsonSchema is empty when using typed schemas, ChatCompletionsRequest fell back to responseMimeType.equals("application/json") and downgraded the request's response_format to {"type": "json_object"}. As a result, the defined schema was ignored and dropped from the OpenAI-compatible /chat/completions request.
Solution:
Testing Plan
Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.
Unit Tests:
Manual End-to-End (E2E) Tests:
Built and verified a reproduction test harness that creates an LlmRequest with an outputSchema(Schema), converts it via ChatCompletionsRequest.fromLlmRequest(request, false), and serializes it with Jackson:
Before Fix: Serialized output emitted {"type": "json_object"} without the schema.
After Fix: Serialized output emits {"type": "json_schema", "json_schema": {...}} preserving all defined fields (rootCause, confidence) and strict: true.
Checklist