Repository navigation
fix(cli): keep punctuation-only speaker turns in tts --multi-speaker - #75
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
copybara/994674353
branch
from
October 6, 2026 23:04
913106d to
a43abb5
Compare
Bounding `lineMarkerStart` at the previous label also made "only whitespace since the previous label" count as the start of a line, so a punctuation-only turn after a label on the same line was read as the next label's list marker and dropped with it (`Alice: ... Bob: Yes?`, `Alice: — Bob: Sorry, go on.`, and `Alice: ?! Bob: What?` each sent only Bob's turn). Judge the line start on the whole text (`text[:floor+len(rest)]`) for every marker. The scan still stops at the previous label (`floor`), so emoji names (`😀: 🤖:`) do not overlap or panic. PiperOrigin-RevId: 994686637
copybara-service
Bot
force-pushed
the
copybara/994674353
branch
from
October 6, 2026 23:07
a43abb5 to
3633e3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(cli): keep punctuation-only speaker turns in
tts --multi-speakerBounding
lineMarkerStartat the previous label also made "only whitespace since the previous label" count as the start of a line, so a punctuation-only turn after a label on the same line was read as the next label's list marker and dropped with it (Alice: ... Bob: Yes?,Alice: — Bob: Sorry, go on., andAlice: ?! Bob: What?each sent only Bob's turn).Judge the line start on the whole text (
text[:floor+len(rest)]) for every marker. The scan still stops at the previous label (floor), so emoji names (😀: 🤖:) do not overlap or panic.