[bot] Merge master/a1ccba8e into rel/dev - #1726
Merged
Merged
Conversation
Greenplum is no longer used by any customer and is being removed from the backend (F1-2435), so the SDK no longer needs to model it. Drops the hand-written `CatalogDataSourceGreenplum` and `GreenplumAttributes` classes, their exports from `gooddata_sdk`, and the Greenplum example from the data-source docs. The Greenplum test went with them: it was already inert, sitting inside a `"""` block and referencing a `greenplum.yaml` cassette that does not exist in the repo. The generated client was updated the supported way rather than by hand. The `GREENPLUM` enum entry was removed from the two source schemas it originates from -- gooddata-metadata-client.json and gooddata-scan-client.json -- and `gooddata-api-client/` was then regenerated with openapi-generator against the merged schema. The regeneration produced exactly six deletions and no other drift, which also confirms the checked-in client was in sync with the schemas. The merged schemas/gooddata-api-client.json was edited line-wise instead of being rebuilt through the Makefile's `jq -S -s` step. jq 1.6 does not preserve number literals and rewrote unrelated values (2.6E+9 -> 2600000000, 1.0 -> 1) across the file; the checked-in copy was produced with jq 1.7+, which does. This is a breaking change for anyone importing either class by name, including code that never connects to Greenplum, since the failure is at import time. JIRA: F1-2435 risk: low Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
refactor: remove support for Greenplum
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rel/dev #1726 +/- ##
===========================================
- Coverage 79.16% 79.15% -0.01%
===========================================
Files 271 271
Lines 18801 18794 -7
===========================================
- Hits 14883 14876 -7
Misses 3918 3918 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Automated PR to perform merge from master into rel/dev with changes up to a1ccba8 (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/31384243736).