feat(eval): add gooddata-eval model-evaluation CLI#1639
Merged
Conversation
zdenekmusil-gd
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
zdenekmusil-gd
force-pushed
the
zmu/gdai-1766-gooddata-eval-cli
branch
from
a7d2af0 to
decddb3
Compare
Contributor
|
Looks good! We need to add also infra things. Please add the new package also in the following places:
Also, package is missing common Makefile. See https://github.com/gooddata/gooddata-python-sdk/blob/master/packages/gooddata-dbt/Makefile#L1-L1 for instance. Just copy paste to to the new package. |
zdenekmusil-gd
force-pushed
the
zmu/gdai-1766-gooddata-eval-cli
branch
from
decddb3 to
c5b69b5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1639 +/- ##
=======================================
Coverage 79.10% 79.10%
=======================================
Files 231 231
Lines 15718 15718
=======================================
Hits 12433 12433
Misses 3285 3285 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zdenekmusil-gd
force-pushed
the
zmu/gdai-1766-gooddata-eval-cli
branch
from
c5b69b5 to
d90f37d
Compare
… + Langfuse) New public package `gooddata-eval` with a `gd-eval` CLI that evaluates the GoodData AI agent against a dataset of natural-language questions. Phase 1 — visualization evaluation: - Layered core + thin argparse CLI; SSE agentic chat client (httpx); workspace LLM provider/model resolution and activation via GoodData SDK; local-folder and Langfuse dataset sources; visualization evaluator with strict checks (metrics/dimensions/filters/type, cross-ref, pass@K); console + JSON reports. - Streaming per-item progress with latency (total, avg) and quality score. - Provider flag accepts name or id; auto-switches workspace to the provider that offers the requested model. - SSE fallback: captures visualization from create_adhoc_visualization tool call args when the data source is inaccessible. Phase 2 — remaining agentic test kinds: - metric_skill, alert_skill, search_tool: scored via tool call arguments. - general_question + guardrail: LLM-as-judge via openai [llm-judge] extra, lazily imported so CLI starts without openai installed. - Shared helpers: _deep_subset, LLMJudge, _text_utils. Langfuse integration: - Dataset source uses REST API via httpx (no Langfuse SDK — broken on Python 3.14). Requires LANGFUSE_PUBLIC_KEY / SECRET_KEY / HOST env vars. - Scoring sink (--langfuse, requires --langfuse-dataset): posts trace + 4 scores + dataset-run-item per evaluated item, creating the named experiment run automatically in Langfuse. - Scores: pass_at_k, quality_score, value_score, latency_s. Bug fixes from code review: - general_question/guardrail items SKIPPED (not ERRORED) when openai absent: supported_test_kinds() now checks openai availability via find_spec(). - Guardrail quality_score was inverted: visualization_returned renamed to no_visualization (True=good); judge_passed added so prose compliance scores 0.5 rather than 1.0. - _coerce_number truncated float thresholds: float(int(x)) -> float(x). - Falsy-zero threshold: 'or' fallback replaced with 'in' key check. - conversationId KeyError on malformed 200: raises ValueError with body. - Scoring math in sink.py was duplicated inline: now calls compute_scores(). - _deep_subset docstring corrected: greedy first-fit, not bipartite match. Infra wiring: - Add to fossa.yaml matrix, build-release/dev-release COMPONENTS, codecov. - Add Makefile (include ../../project_common.mk). 102 tests, ruff + ty clean. CLI starts without openai installed. JIRA: GDAI-1766 Risk: low — new isolated package; no changes to existing packages.
zdenekmusil-gd
force-pushed
the
zmu/gdai-1766-gooddata-eval-cli
branch
from
d90f37d to
6ab0749
Compare
hkad98
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New public package
gooddata-evalwith agd-evalCLI that evaluates the GoodData AI agent against a dataset of natural-language questions.JIRA: GDAI-1766
Risk: low — new isolated package; no changes to existing packages.