Repository navigation
Use sets for file membership lookups - #264
Merged
Merged
Conversation
Track the files seen while squashing in sets instead of lists. The squashed-file, per-layer file and marker-file collections are only used for membership tests and additions, so list scans become O(1) lookups. Add type hints for the changed collections (typing module forms, so they remain valid on Python 3.7) and a unit test for _files_in_layers covering normalisation of './' prefixed names and the set return type. Extracted from the "Better squashing" rewrite in goldmann#254 Co-authored-by: Nixxx11 <nixx@list.ru>
goldmann
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Track the files seen while squashing in sets instead of lists. The squashed-file, per-layer file and marker-file collections are only used for membership tests and additions, so list scans become O(1) lookups.
Add type hints for the changed collections (typing module forms, so they remain valid on Python 3.7) and a unit test for _files_in_layers covering normalisation of './' prefixed names and the set return type.
Extracted from the "Better squashing" rewrite in
#254