Don't end ext_wrappers.gen.inc macros with a backslash-newline - #2040
Open
Faless wants to merge 1 commit into
Open
Don't end ext_wrappers.gen.inc macros with a backslash-newline#2040Faless wants to merge 1 commit into
Faless wants to merge 1 commit into
Conversation
Collaborator
|
Thanks! However, I'm not sure this is right fix All the #define MODBIND0( m_name) \
virtual void _##m_name() override; \
That second line probably shouldn't even end with a |
Fixes warning when including ext_wrappers.gen.inc: godot-cpp/gen/include/godot_cpp/core/ext_wrappers.gen.inc:181:148: warning: backslash-newline at end of file
Faless
force-pushed
the
fix/backslash-newline
branch
from
August 10, 2026 14:22
cf7d3ef to
f44bed5
Compare
Contributor
Author
Ah, indeed, that is not needed, I was too focused on the fix that I didn't think of it 😅 . Fixed, thanks! |
Faless
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes warning when including ext_wrappers.gen.inc: