Repository navigation
perf: a deadline only for Tab, not for every key - #8
Merged
Merged
Conversation
Session.key made a context.WithTimeout (four allocations and a runtime timer) for every keystroke, though only Tab asks the completer. Other keys now get context.Background(). Per key: 11 to 7 allocations. Refs wasmdesk/wasmbox#175. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Session.keycreated acontext.WithTimeout(CompleteTimeout)for every keystroke, but only Tab reaches the completer. That is four allocations and a runtime timer per key for nothing. Only Tab now gets the deadline; every other key getscontext.Background().Measured through wasmbox's keystroke benchmark (type a key, erase it; allocations are exact, times indicative: 1-minute load 9.9, above the 8 limit):
TestTabCompletionHasADeadlinekeeps the deadline on Tab. 100 % coverage,-raceclean. Refs wasmdesk/wasmbox#175.🤖 Generated with Claude Code