Repository navigation
feat: Options.Prompt, a prompt that follows the shell - #6
Merged
Merged
Conversation
Options.Prompt (optional) returns the prompt; the session asks for it at Attach/SetShell and after each command, once Run has returned, so a host can show a working directory or the last status. Control characters are dropped, an empty answer keeps the previous prompt, and the default stays "$ ", so existing users (go-wasmcontainers/dashboard v0.9.0) are unchanged. Additive: v0.1.1. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Options.Prompt func() string, so a host can show state the shell changes (a working directory, the last status). wasmdesk/wasmbox's terminal needs it: it showed the working directory in its prompt before the move to shellterm.Refs wasmdesk/wasmbox#173
Attach/SetShelland after each command, on the session goroutine with the session locked, onceRunhas returned.$: dashboard v0.9.0 and any caller that does not set it are unchanged.TestSessionPromptHook),-raceclean; README updated.🤖 Generated with Claude Code