perf: reuse buffer when hashing source files for checksums#2925
Open
vmaerten wants to merge 1 commit into
Open
perf: reuse buffer when hashing source files for checksums#2925vmaerten wants to merge 1 commit into
vmaerten wants to merge 1 commit into
Conversation
io.CopyBuffer ignored the pre-allocated buffer because *os.File implements WriterTo: it took the (*os.File).WriteTo path, which allocates a fresh 32KiB buffer per file via os.genericWriteTo. Hashing many small source files thus allocated ~32KiB per file (~640MB for 20,000 files). Wrapping the file in a plain io.Reader forces io.CopyBuffer to reuse the caller's buffer, keeping the loop allocation-free. The checksum value is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
io.CopyBufferignored the pre-allocated buffer because*os.FileimplementsWriterTo: it took the(*os.File).WriteTopath, which allocates a fresh 32KiB buffer per file via os.genericWriteTo. Hashing many small source files thus allocated ~32KiB per file (~640MB for 20,000 files).Wrapping the file in a plain
io.Readerforcesio.CopyBufferto reuse the caller's buffer, keeping the loop allocation-free. The checksum value is unchanged.