Repository navigation
rbtest: a bench module nested below bench/ belongs to the repository too - #19
Merged
Merged
Conversation
checkRoot accepted the root module or its direct child only (path.Dir(self) == root), so go-simd/floats, whose perf module is bench/perf, was refused as if it were another repository's binary. The rule is now ownsModule: the same module or any module below it, which still refuses a sibling that merely shares a prefix (github.com/o/rx). Tested both ways in TestOwnsModule and TestRootGuard (bench/perf allowed, a prefix sibling refused); restoring the direct-parent rule turns both red. Fixes #18 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18.
checkRootaccepted the root module or its direct child only, so a perf module atbench/perfwas refused as if it belonged to another repository. go-simd/floats keeps its perf module there, so it could not move from refbench v0.1.2 to v0.4.0 for the per-row retries and-perf.resume, which it needs on a loaded machine.ownsModule(root, self): the same module, or any module belowroot + "/". A sibling that only shares a prefix (github.com/o/rx) is still refused, and so is a module of another owner.TestOwnsModulecovers both directions in eight cases, andTestRootGuardaddsexample.com/lib/bench/perf(allowed) andexample.com/libx/bench(refused).🤖 Generated with Claude Code