Skip to content

commit check: assume-unchanged files, dependency bumps via bench/go.mod, and go.work can still change the measured code #14

Open

Description

@tannevaled

The independent review of #13 (commit check) listed three low-severity gaps it did not block on. Each one lets a measured tree differ from the recorded commit without a refusal:

  1. assume-unchanged / skip-worktree. Files with either index bit set do not appear in git status, so local edits to them are invisible. Possible fix: git ls-files -v and refuse when a file carries a lowercase tag (assume-unchanged) or S (skip-worktree).
  2. Another module's require bumped in bench/go.mod. This is accepted by design, but minimal version selection can raise one of the library's own dependencies, so the library is measured with different dependency code. Possible fix: compare go list -m all for the library's module graph at HEAD and in the measured build, and refuse on any difference outside bench/.
  3. go.work / GOWORK. A workspace file above the repository, or the GOWORK variable, can replace the library or its dependencies without touching the tree. Possible fix: run the check with GOWORK=off, or refuse when go env GOWORK is non-empty.

Refs #12, #13

Prior art: priorart "perf.commit must equal HEAD sha" at 2026-11-12 10:43 CET reported prior art; checked: priorart this morning: 14 matches, none about commit verification; #12/#13 are the check itself, these are its reviewed residual gaps

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions