Repository navigation
fix(parser): accept four constructs MRI allows but the parser rejected - #20
Merged
Merged
Conversation
Four unrelated syntax gaps, each of which made whole ruby/spec files fail
to load; all are now parsed as MRI 4.0.6 does, with tests:
* `return/break/next *ary` — a `*splat` jump value gathers into an
implicit array (`return [*ary]`), like `x = *ary`.
* `{ |a,| }` — a trailing comma in a block parameter list forces array
destructuring of a single argument (equivalent to an anonymous rest
`|a, *|`), so `[1, 2]` yields `a == 1`.
* `cond ? next : x` — a bare value-less control-flow jump is allowed as
a ternary arm (reusing valuelessJumpOperand, already used for
`&&`/`||` operands).
* `:$~` `:$!` `:$-w` `:$1` — symbols naming the special/option/match
global variables now lex, mirroring the global-variable lexer.
go vet, the full suite and the 100% merged-coverage gate stay green.
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four unrelated syntax gaps, each of which made whole ruby/spec files fail to load; all now parse as MRI 4.0.6 does, each with a test:
return/break/next *ary— a*splatjump value gathers into an implicit array (return [*ary]), likex = *ary.{ |a,| }— a trailing comma in a block parameter list forces array destructuring of a single argument (equivalent to an anonymous rest|a, *|), so[1, 2]yieldsa == 1.cond ? next : x— a bare value-less control-flow jump is allowed as a ternary arm (reusingvaluelessJumpOperand, already used for&&/||operands).:$~:$!:$-w:$1— symbols naming the special / option / match-group global variables now lex, mirroring the global-variable lexer.go vet, the full suite and the 100% merged-coverage gate stay green.