Skip to content

test: compile and run the suite on 32-bit targets; pin the asm generator - #10

Merged
tannevaled merged 1 commit into
mainfrom
ci/32bit-and-all-targets
Oct 4, 2026
Merged

tannevaled merged 1 commit into
mainfrom
ci/32bit-and-all-targets

Conversation

@tannevaled

Copy link
Copy Markdown
Contributor

overflow_test.go wrote its overflowing shapes as 1<<62 and 1<<40 literals,
which do not compile where int is 32 bits, so go test failed to build on
linux/386, arm, mips and mipsle. The extents are now derived from
bits.UintSize, so the same products overflow on both word sizes; the suite
passes on real 386 hardware.

Nothing caught this because CI never ran a 32-bit target. Three lanes now
cover it:

  • arch 386: GOARCH=386 natively on the amd64 runner (not qemu-i386).
  • arch arm (qemu): a 32-bit ARM lane beside the existing qemu ones.
  • compile tests on every target: go test -c for each go tool dist list
    pair (go vet for android/ios, which cannot link without cgo). Checked
    with a planted 1<<62 literal, which both modes refuse.

The asm generators carried //go:build ignore, so go mod tidy saw no
import of go-asmgen and dropped the requirement. Renovate's "update to
v0.9.0" (#6) did exactly that, leaving CI to resolve whatever version
-mod=mod found. The tag is gone (each generator is the only file of its
own main package), and go-asmgen is pinned at v0.10.0 again, which
regenerates the committed .s byte for byte.

🤖 Generated with Claude Code

overflow_test.go wrote its overflowing shapes as 1<<62 and 1<<40 literals,
which do not compile where int is 32 bits, so `go test` failed to build on
linux/386, arm, mips and mipsle. The extents are now derived from
bits.UintSize, so the same products overflow on both word sizes; the suite
passes on real 386 hardware.

Nothing caught this because CI never ran a 32-bit target. Three lanes now
cover it:
- arch 386: GOARCH=386 natively on the amd64 runner (not qemu-i386).
- arch arm (qemu): a 32-bit ARM lane beside the existing qemu ones.
- compile tests on every target: `go test -c` for each `go tool dist list`
  pair (`go vet` for android/ios, which cannot link without cgo). Checked
  with a planted 1<<62 literal, which both modes refuse.

The asm generators carried //go:build ignore, so `go mod tidy` saw no
import of go-asmgen and dropped the requirement. Renovate's "update to
v0.9.0" (#6) did exactly that, leaving CI to resolve whatever version
-mod=mod found. The tag is gone (each generator is the only file of its
own main package), and go-asmgen is pinned at v0.10.0 again, which
regenerates the committed .s byte for byte.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@tannevaled
tannevaled merged commit 675ef3d into main Oct 4, 2026
12 checks passed
@tannevaled
tannevaled deleted the ci/32bit-and-all-targets branch October 4, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant