Conversation
The gpg and ssh signer modules gained a context parameter on Sign in v0.2.0 so callers can cancel external/remote signing (e.g. an external program or agent). Bump auto to those releases and thread the context through its own Signer interface to match, updating the tests to pass t.Context(). Assisted-by: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: Paulo Gomes <paulo@entire.io> Entire-Checkpoint: 3628d6eded27
There was a problem hiding this comment.
Pull request overview
Updates the objectsigner/auto module to align with gpg/ssh signer v0.2.0, which adds context.Context support to Sign so callers can cancel signing operations.
Changes:
- Bump
github.com/go-git/x/plugin/objectsigner/{gpg,ssh}dependencies tov0.2.0. - Update
auto.SignertoSign(ctx context.Context, message io.Reader)and document context behavior. - Update tests to pass
t.Context()intoSign.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| plugin/objectsigner/auto/go.mod | Bumps gpg/ssh signer module dependencies to v0.2.0. |
| plugin/objectsigner/auto/go.sum | Adds checksums for the v0.2.0 gpg/ssh modules. |
| plugin/objectsigner/auto/auto.go | Updates exported Signer interface to include context.Context. |
| plugin/objectsigner/auto/auto_test.go | Updates all signer invocations to pass t.Context(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hiddeco
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
gpgandsshsigner modules gained a context parameter on Sign inv0.2.0so callers can cancel external/remote signing (e.g. an external program or agent). Bump auto to those releases and thread the context through its own Signer interface to match, updating the tests to passt.Context().