Repository navigation
Bump go-ruby-parser to v0.1.5 (parenthesised call-arg assignment fix) - #503
Merged
Merged
Conversation
go-ruby-parser v0.1.5 fixes a parser defect where an assignment used as a parenthesised call argument (or array element) gathered its right-hand side across commas into an implicit array: primitive_convert(src = +"…", dst = +"", nil, 10) parsed as a single argument src = [+"…", dst = [+"", nil, 10]] instead of four arguments, so the call failed with "no implicit conversion of Array into String". This is the standard mspec idiom for the mutating Encoding::Converter methods, and more generally f(a = 1, b = 2, 3) now parses as three arguments. ruby/spec ratchet FLOOR 16285 -> 16315 (measured total 16355). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
tannevaled
force-pushed
the
feat/parser-v0.1.5
branch
from
August 30, 2026 11:37
b7d0615 to
401601a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go-ruby-parser v0.1.5 fixes a parser defect where an assignment used as a parenthesised call argument (or array element) gathered its right-hand side across commas into an implicit array:
The comma inside
(…)/[…]separates arguments, so multiple-assignment detection is now off there (as it already was for paren-less commands anddefdefaults).f(a = 1, b = 2, 3)now parses as three arguments;a = 1, 2, 3at statement level still gathers its array RHS.This is the standard mspec idiom for the mutating
Encoding::Convertermethods (primitive_convert/putbackspecs), verified byte-for-byte against MRI Ruby 4.0.6.Conformance: ruby/spec ratchet FLOOR 16285 → 16315 (measured total 16355).
go test ./...green, native +wasip1/wasmbuild, gofmt clean.🤖 Generated with Claude Code