Skip to content

Import the landing kit as a Hugo module instead of a variant copy - #18

Merged
tannevaled merged 1 commit into
mainfrom
landingkit
Oct 11, 2026
Merged

tannevaled merged 1 commit into
mainfrom
landingkit

Conversation

@tannevaled

Copy link
Copy Markdown
Contributor

Aligns the landing (and /performance/) on go-fleettools/landingkit v0.2.0, the way go-fileshare.github.io#24 did for the reference.

What changes

  • hugo.toml imports the module; go.mod pins v0.2.0; kit.go (//go:build tools) keeps Renovate's go mod tidy from deleting the requirement; actions/setup-go runs before Hugo in deploy-pages.yml.
  • Deleted: the variant styles.html, theme-toggle.html and icons/mark-github.html (now the kit's icons/github.html). icons/rocket.html and icons/graph.html stay as the site's own Octicons, with OCTICONS-LICENSE.
  • [params.brand] is new, generated by landingkit brand static/img/logo.svg: base #9b1c2e, deep #5f111c, bright #f0475a, the logo's own crimson. The variant sheet had a red written into its rules that is not the logo's: #DC2626 → #7F1D1D, dark accent #f2686d, plus the stats gradient #ffd9d9 and band text #ffe1e1.
  • On both the landing and /performance/, the nav bar's GitHub button is replaced by the fork ribbon, pointing at go-embedded-ruby/ruby (where the button led).
    • The hero's primary "Get started →" also leads to that repository. I kept it: it is the page's call to action, not a "Browse the source" button. Say if it should go too.
  • darkreader-lock comes from the kit; the layouts had no duplicate.
  • No page-specific rules: the performance page's rules (.phero, .psec, table.bench, …) are already in the kit, so there is no site-styles.html.

Verification

  • landingkit verify go-embedded-ruby.github.io go-fileshare.github.io:
    PASS the <style> block equals the reference's once brand values are masked
    FAIL light: 2/9 background pixels differ, e.g. (4, 900) site #f7f8fb ref #ffffff, (1275, 1000) site #f7f8fb ref #ffffff
    FAIL dark: 2/9 background pixels differ, e.g. (4, 900) site #111620 ref #0b0e14, (1275, 1000) site #111620 ref #0b0e14
    
    The pixel FAIL is not a tinted surface. Two of the nine samples (y=900 and y=1000) land inside this page's .strip, which is 444px tall here, and its background is the kit's own --bg-soft (#f7f8fb / #111620). At those heights the reference page shows plain background. main gives the identical pixel result (same two samples, same colours). This is a limit of verify's fixed sample points, not a difference in the sheet.
  • Puppeteer at 1280, 1440 and 390 (mobile emulation with setViewport), light and dark, on / and /performance/: no horizontal scroll on main or on the branch. The theme toggle is hit-tested and clicked and changes data-theme. The ribbon is hit-tested and clickable at every width.

Visual differences, section by section (main vs branch, screenshots)

  • Nav (both pages): the GitHub button is gone, and the fork ribbon sits in the top-right corner. Below 1420px the nav reserves room for it.
  • Hero / performance hero: the red moves from #DC2626 → #7F1D1D to the logo's #9b1c2e → #5f111c, a darker, more crimson accent. This shows in the "written in Go." accent, the "Get started" button and the washes. In dark mode the accent goes from #f2686d to #f0475a.
  • CTA band (#eco): the same gradient change (most of its pixel difference). The band text goes from #ffe1e1 to the kit's #d8f3fb.
  • Stats (#perf): the number gradient ends in the kit's #cdf1fa instead of #ffd9d9.
  • Features, Roadmap, performance tables: chip and tag colours follow the brand block (0.3–6% of pixels); no layout change.
  • Strip and footer: pixel-identical at desktop widths.

Checks

No check changes: deploy-pages (build).

🤖 Generated with Claude Code

The page carried its own styles.html with a ruby red written into the
rules (#DC2626 -> #7F1D1D) that is not its logo's. It now imports
github.com/go-fleettools/landingkit v0.2.0 (hugo.toml [module], go.mod,
kit.go, setup-go before Hugo), and [params.brand] is generated by
`landingkit brand static/img/logo.svg`: base #9b1c2e, deep #5f111c,
bright #f0475a, the logo's own crimson.

The nav bar's GitHub button, on the landing and on /performance/, gives
way to the fork ribbon pointing at go-embedded-ruby/ruby. mark-github.html
is the kit's icons/github.html. The variant sheet had no rule the kit
lacks, so there is no site-styles.html.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@tannevaled
tannevaled merged commit b528c53 into main Oct 11, 2026
2 checks passed
@tannevaled
tannevaled deleted the landingkit branch October 11, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant