fix: resolve HybridView config via react-native package exports - #62
fix: resolve HybridView config via react-native package exports#62jkasprzyk17 wants to merge 1 commit into
Conversation
Point Metro to src/ so Nitrogen MapViewConfig.json imports work without consumer metro.config.js hacks after bob emits lib/module/.
|
React Doctor found 8 issues in 5 files · 2 errors & 6 warnings · score 64 / 100 (Needs work) · full project Errors
6 warnings
Reviewed by React Doctor for commit |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
Included review availability: 3 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughSummary by CodeRabbit
WalkthroughThe package now exposes React Native entries through the ChangesReact Native resolution
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The localized export-condition change routes HybridView imports through src and removes the example resolver workaround; no concrete correctness or merge-blocking risk remains beyond normal checks. Suggested reviewers: 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.) Full details: Security CheckExplanation No medium-, high-, or critical-severity vulnerability is introduced. The diff changes only static package metadata, Metro condition configuration, and documentation. The new Comment |
Summary
react-nativeentry andexports.react-nativeso Metro resolvessrc/instead oflib/module/for HybridView importsMapViewConfig.jsonimport path as documented (../../nitrogen/...fromsrc/native/)react-nativeexport conditionWhy
Bob emits
MapViewNativeunderlib/module/native/, so../../nitrogen/...resolves tolib/nitrogen/and breaks for consumers loading the compiled package. Resolvingsrc/matches the Nitro HybridView packaging pattern used by nitro-image and Vision Camera.Test plan
bun run typecheckMapViewConfig.jsonmetroresolveRequesthack and confirm the app bundlesexample/metro.config.js