Repository navigation
chore(dev): scope and quiet the lint checker - #3596
Merged
Merged
Conversation
`vite-plugin-checker` logs `[oxlint] Found 0 error and 0 warning` after every lint run, clean or not, so each save during `pnpm dev` printed a line that reported nothing. Its `dev.logLevel` only filters diagnostics, so drop the clean summary from a custom dev-server logger. Errors and their summaries still print. The checker also watched its root, which includes output that dev rewrites constantly: `build/` on every Electron rebuild and the GraphQL generated modules on every codegen run. Neither is linted, so those runs only burned CPU. Limit the watcher to the linted sources and root config files; the startup run still lints the whole project.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnpm devprints a[oxlint] Found 0 error and 0 warningline after every lint run: one per file save, plus runs triggered by output that dev itself rewrites. Two separate causes:vite-plugin-checkerlogs a summary after every run, clean or not, anddev.logLevelonly filters diagnostics. A custom dev-server logger now drops just the clean summary, so real errors and their summaries still print.build/(rewritten on every Electron rebuild) and the GraphQLgenerated/modules (rewritten on every codegen run) triggered lint runs for files the lint config ignores. The watcher is now limited tosrc,scripts, and the linted root config files. The startup run still lints the whole project, so nothing is missed at boot.Verification
pnpm check: 560 files formatted, 519 files lint/type clean.ERROR(oxlint) … [oxlint] Found 2 errors and 0 warning.Notes
Each per-save run costs about 0.6s CPU for the changed files. Linting still runs in the recommended
oxceditor extension (samevite.config.mtsconfig) and inpnpm checkat pre-commit and in CI.