Repository navigation
fix: respect package-managed updates and user preferences - #3346
afonsojramos wants to merge 7 commits into
Conversation
|
|
This does seem to be a recurring question... my hope is we maintain a user-base which keeps up with our releases and doesn't drift behind 🥲 |
setchy
left a comment
There was a problem hiding this comment.
Thanks Afonso — nice work, and the tests around flipping the setting quickly are great.
some new feedback areas to consider:
-
Rebase. Conflicts with main in 8 files. When resolving: drop the Settings snapshot (main deleted it in #3514), and re-check the new radio buttons against the updated Settings layout (#3492–#3496). Then re-run the unit and visual tests.
-
Defaults — shall we keep Gitify keep handling updates itself where it can.
- Off: Scoop (the bug in #3283), Flatpak, Snap.
- On: deb, rpm, Homebrew, AppImage, direct downloads, and anything we can't identify.
That lets us delete the dpkg/rpm/pacman ownership checks and their tests — less code, no commands at startup. Keep the packager marker/env var, and keep Off available to everyone. Heads up: #3374 (FlatPark) wraps our .deb in a Flatpak, so the Flatpak check needs to stay ahead of any deb/rpm logic.
156a367 to
d9b962b
Compare
|
Rebased onto main and defaults are now Off only for Scoop, Flatpak, and Snap. The pacman/dpkg/rpm ownership checks and their tests are deleted, so detection runs no commands. |
|
|
Approved. I assume you're feeling highly confidence that the OS / package update managers will keep gitify updates going forward once released. I guess users can always override in Settings, correct? |



Summary
Gitify keeps updating itself by default and leaves updates to the package manager only where one owns them, so a Scoop installation no longer gets a second copy installed outside Scoop's directory. A persistent Default / On / Off choice under Settings > System lets every user decide.
disable-auto-updatesfile in the resources directory orGITIFY_DISABLE_AUTO_UPDATE=1in the launcher.On macOS, the native update handoff waits for Restart or for a quit with updates on, because an update already handed to Squirrel cannot be revoked. A plain quit installs without relaunching. A failed later check keeps a downloaded update installable, while a replacement download drops the ready state until it finishes.
Validation
pnpm check,pnpm i18n:check, and all 2,179 unit tests pass.Closes #3283