ci: use setup-vp for JavaScript tooling - #3245
Open
afonsojramos wants to merge 2 commits into
Open
Conversation
setup-vp exposes the Vite+ CLI but not the underlying pnpm binary to subsequent workflow steps. Use Vite+ to run scripts and binaries, and validate Renovate without a global package-manager install.
|
Member
Author
|
@setchy I think that the issue might have been that we only partially adopted vp. With full adoption, we might have no more issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI now lets the official Vite+ action own Vite+, Node.js, pnpm, dependency installation, and pnpm-store caching instead of composing those pieces ourselves. This isolates whether Vite+ materially simplifies Gitify's workflow setup before we decide on the larger toolchain direction.
setup-vpresolves the existing project pins: Vite+ 0.2.9 frompackage.json, Node.js 24.20.0, and pnpm 11.24.0 frompackageManager. Jobs that need dependencies use the action's defaultvp install; Renovate config validation keeps installation disabled.The action uses the pinned package manager internally but does not expose a bare
pnpmexecutable to later workflow steps. Those steps now use Vite+'s supported command surface instead:vp runfor package scripts,vp execfor project binaries, andvp dlxfor the Renovate validator.Related: #3244
Validation
vp dlx --package renovate renovate-config-validator.