chore(deps-core): update electron to v43.4.1 [DO NOT MERGE: regression persists] - #154
Draft
afonsojramos wants to merge 1 commit into
Draft
chore(deps-core): update electron to v43.4.1 [DO NOT MERGE: regression persists]#154afonsojramos wants to merge 1 commit into
afonsojramos wants to merge 1 commit into
Conversation
afonsojramos
marked this pull request as draft
August 20, 2026 12:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Do not merge. The premise of this PR did not hold. Kept as a draft because it is the evidence that 43.4.1 does not fix the Linux tray regression. See Result.
Original intent
Bump
electron43.2.0 → 43.4.1 to skip the Linux tray regression in 43.4.0, on the assumption that electron#52952 (shipped in 43.4.1) fixed it:Result
That assumption was wrong. 43.4.1 fixes part of the problem but the tray icon still never paints.
exactTrayWhat 43.4.1 did fix: waybar's
[error] Invalid Status Notifier Item: ...no longer appears (present exactly once on 43.4.0, zero times on 43.4.1). So electron#52952 landed and corrected the SNI-addressing fault. The icon still does not render, so at least one further defect remains.LXQt is a new failure: it passed on both 43.2.0 and 43.4.0, and fails on 43.4.1.
Version correlation, with a same-day control
All three runs below use the identical harness and workflow on
ubuntu-24.04, on the same day, ruling out runner-image drift:main@389a8a3, 11:43In every failing case the popover window renders correctly (Budgie:
windowWhite=16734 windowBlack=3200, the exact expected counts) and only the tray icon is absent, so this is specific to tray rendering rather than general painting. The retry loop added in #153 exhausts rather than recovering, which rules out a timing race.Consequence
electronshould stay pinned at 43.2.0 until this is resolved upstream. #143 (43.4.0) and this PR (43.4.1) should both stay unmerged.Upstream
Already tracked, so no new issue was filed:
Root cause per the upstream analysis: Chromium's new StatusNotifierItem multiplexer collapses every icon onto a single
/StatusNotifierItemobject path, so the only remaining discriminator is the destination service name. Desktops that address the item by its unique D-Bus connection name (anything built onGio.DBusProxy) can no longer be routed to the right icon, becauseMultiplexer::GetIcon(":1.134")finds nothing. The old code gave each icon its own object path and D-Bus routed by path, which worked under either name form. Arrived via electron#52416 (Chromium 150.0.7871.181).electron#52952, the 43.4.1 change this PR was based on, is described upstream as a bad fix for the same problem. That matches what we measured: it removed waybar's
Invalid Status Notifier Itemerror without making the icon render, and coincided with LXQt breaking.Our matrix adds data the upstream issue does not yet have: Budgie, Sway/Waybar and LXQt are also affected (upstream names GNOME's AppIndicator extension and xApp), KDE Plasma is confirmed unaffected, and 43.4.1 does not resolve it. Failures reproduced on re-run.